Link to comment that raised the issue (Lido core repo): NomicFoundation/lidofinance-core#1 (comment)
In Hardhat 2 the chai matchers providered asserts on revert with the following syntax:
await expect(vaultHub.obligationsShortfallValue(vault)).not.to.be.reverted
Implicit in this is that the revert was happening on the ambient network connection for that current HRE instanct.
In Hardhat 3 there can be many connections and network.ethers instances, hence the particular ethers instance has to be passed to the assert:
await expect(vaultHub.obligationsShortfallValue(vault)).not.to.revert(ethers);
This is annoying boilerplate. Can this be improved?
Link to comment that raised the issue (Lido core repo): NomicFoundation/lidofinance-core#1 (comment)
In Hardhat 2 the chai matchers providered asserts on
revertwith the following syntax:Implicit in this is that the revert was happening on the ambient network connection for that current HRE instanct.
In Hardhat 3 there can be many connections and
network.ethersinstances, hence the particularethersinstance has to be passed to the assert:This is annoying boilerplate. Can this be improved?