Migrate ShardQueryLogicQueryValidationTest from Arquillian to JUnit5/Spring#3673
Merged
apmoriarty merged 1 commit intoJul 13, 2026
Merged
Conversation
…Spring Drops the Arquillian container deployment in favor of SpringExtension with the same context config used by the AbstractQueryTest-based tests. This test calls ShardQueryLogic.validateQuery() directly and asserts on QueryRuleResult/exception state, never planning or executing a query, so it doesn't fit AbstractQueryTest's plan/execute/assert-results model at all; it's modernized to plain JUnit5 instead, same as the other non-ShardQueryLogic-flow test files. Also swaps the QueryTestTableHelper instance-name label from the still-unmigrated ShardQueryLogicTest.ShardRange (borrowed only for a unique string, no functional dependency) to this class's own name, since that reference would otherwise break once ShardQueryLogicTest.ShardRange is removed by a later migration. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lbschanno
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the Arquillian container deployment in favor of SpringExtension with the same context config used by the AbstractQueryTest-based tests. This test calls ShardQueryLogic.validateQuery() directly and asserts on QueryRuleResult/exception state, never planning or executing a query, so it doesn't fit AbstractQueryTest's plan/execute/assert-results model at all; it's modernized to plain JUnit5 instead, same as the other non-ShardQueryLogic-flow test files. Also swaps the QueryTestTableHelper instance-name label from the still-unmigrated ShardQueryLogicTest.ShardRange (borrowed only for a unique string, no functional dependency) to this class's own name, since that reference would otherwise break once ShardQueryLogicTest.ShardRange is removed by a later migration.