MKVNOTE: Extra text embeded for ENCODER_SETTINGS

[chialinchou1]

When manually clear all tags content (delete text one by one and hit "Tag on"), extra value was tagged into ENCODER_SETTINGS and Title:

Terminal output shows:

AUDIO_STREAM_HASH ... (ecad8f5cfdd07978ae79674a42aa8c90)
ENCODER ... (Lavf59.27.100)
ENCODER_SETTINGS ... ("
ORIGINAL_MEDIA_TYPE=""
TAGGED_BY=""
TERMS_OF_USE=""
TITLE=""
_ORIGINAL_FPS=""
_TECHNICAL_NOTES=")
TITLE ... ("
_ORIGINAL_FPS=""
_TECHNICAL_NOTES=")
The file is being analyzed.
The changes are written to the file.
Done.

@dericed @BleakleyMcD

[dericed]

hey @chialinchou1 which branch was this on?

[chialinchou1]

@dericed @BleakleyMcD

Just merged PR #128 and #130 and test on main branch. Long description text and the repeating tags issues are resolved. But this issue persists for empty fields in csv or if you delete a content of a field/tag in GUI:

using this csv (the same one for previous tests)

one_inch_embedded_metadata_cc4.csv

[dericed]

can you send an 'ffmpeg -i' on the input file

[chialinchou1]

like this?
mkvnote_ffmpeg_i.txt

[dericed]

Thanks, I can see this file got messed up from a prior broken version of mkvnote. Could you retry with another file and I'll see about a repair strategy for this one.

[chialinchou1]

1. used two "clean" mkv files, batch csv tagging works, but long text doesn't wrapped if no line break (see Description):

one_inch_embedded_metadata_cc6.csv

2. modify the csv file to edit the tags, it edits, but doesn't delete the value if a cell is empty (row 3 in attached csv file)

one_inch_embedded_metadata_cc7.csv

Question: could we put "delete" in the cell, so that the script knows to delete the content of this tag?

3. manually delete all tag values (except stream hashes and encoder) on GUI and "Tag On", it still adds extra text: "
   _ORIGINAL_FPS="

terminal output:

AUDIO_STREAM_HASH ... (947b6b4c2da3da9283ce80c3b7255c51)
ENCODER ... (Lavf59.27.100)
VIDEO_STREAM_HASH ... (d93f9c6e2f4e205b3f191ada5b93dbf0"
_ORIGINAL_FPS=")
The file is being analyzed.
The changes are written to the file.
Done.

[chialinchou1]

break 1 and 2 into #131 and #132

follow up 3 (this issue), the extra text "
_ORIGINAL_FPS="

seems to only added to whichever last tag analyzed. Tried delete the text, or replace with other text, it gets added back in.

@dericed @BleakleyMcD

[chialinchou1]

@dericed want to follow up on this issue about extra text being appended to the last tag:

cc @BleakleyMcD

[chialinchou1]

This issue persists when running mkvnote with command:
./mkvnote test.mkv

but should be resolved by mkvnote-blake branch