tokens(pure-black): increase border.muted contrast for better separators#1383
Closed
georgewrmarshall wants to merge 1 commit into
Closed
tokens(pure-black): increase border.muted contrast for better separators#1383georgewrmarshall wants to merge 1 commit into
georgewrmarshall wants to merge 1 commit into
Conversation
…ors on pure black Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
Contributor
📖 Storybook LinksCompare the preview for this pull request with the latest Storybooks from the 🔀 Pull Request Preview
🌳 Main Branch (Latest)
|
Contributor
Author
|
Not sure what this is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increase the
border.mutedcontrast in the pure black dark theme to improve the visibility of dividers and subtle separators on#000000backgrounds. This directly addresses low-contrast separators observed in settings-like lists (e.g., the “Region” area) when pure black is enabled by default.Changes:
pureBlackDarkTheme.colors.border.mutedfrom#e2e2ff26→#e2e2ff33--color-border-mutedfrom#e2e2ff26→#e2e2ff33This is a safe, global token-level adjustment that benefits both React Native (twrnc) and Web (CSS variables) consumers without altering component APIs.
Related issues
Manual testing steps
yarn storybook):yarn storybook:ios/android):SectionDivider,ListItem, and settings-like list stories; confirm muted borders are more legible.Screenshots/Recordings
Before
After
Pre-merge author checklist
Slack Thread