From 37badded3a4a07fc042e4ffefa48cb1d0575c845 Mon Sep 17 00:00:00 2001
From: cjee21 <77721854+cjee21@users.noreply.github.com>
Date: Fri, 22 May 2026 14:09:21 +0800
Subject: [PATCH 1/3] ShellExt: Add debug printing

---
 Source/WindowsShellExtension/dllmain.cpp | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/Source/WindowsShellExtension/dllmain.cpp b/Source/WindowsShellExtension/dllmain.cpp
index 53e07725f..ef5e918ec 100644
--- a/Source/WindowsShellExtension/dllmain.cpp
+++ b/Source/WindowsShellExtension/dllmain.cpp
@@ -16,6 +16,13 @@
     #define SHELLEXT_GUID "20669675-b281-4c4f-94fb-cb6fd3995545"
 #endif // MEDIAINFO_QT
 
+//#define MEDIAINFO_DEBUG // Uncomment to view debug printing using https://learn.microsoft.com/en-us/sysinternals/downloads/debugview
+#ifdef MEDIAINFO_DEBUG
+    #define DebugPrintW(...) OutputDebugStringW(wil::str_printf<std::wstring>(L##__VA_ARGS__).c_str())
+#else
+    #define DebugPrintW(...)
+#endif // MEDIAINFO_DEBUG
+
 constexpr const wchar_t* menu_entry_title = L"MediaInfo";
 constexpr const wchar_t* exe_filename = L"MediaInfo.exe";
 
@@ -456,6 +463,8 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
         // Provide state of File Explorer context menu entry
         // Hide it if registry setting indicates that it should be disabled or file is unsupported, else it is enabled
 
+        DebugPrintW("[MediaInfoShellExt] GetState called.\n");
+
         if (!okToBeSlow) {
             *cmdState = ECS_DISABLED;
             // returning E_PENDING requests that a new instance of this object be called back
@@ -472,6 +481,7 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
         if (ShellExtension.has_value() && !ShellExtension.value() && ShellExtension_Folder.has_value() && !ShellExtension_Folder.value())
 #endif // MEDIAINFO_QT
         {
+            DebugPrintW("[MediaInfoShellExt] Hidden by MediaInfo settings in registry.\n");
             *cmdState = ECS_HIDDEN;
             return S_OK;
         }
@@ -548,6 +558,8 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
         // Process items passed by File Explorer when context menu entry is invoked
         UNREFERENCED_PARAMETER(bindCtx);
 
+        DebugPrintW("[MediaInfoShellExt] Invoke called.\n");
+
         // Return if no items
         if (!items)
             return S_OK;
@@ -624,17 +636,20 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
                 wil::unique_cotaskmem_string path;
                 result = item->GetDisplayName(SIGDN_FILESYSPATH, &path);
                 if (SUCCEEDED(result)) {
+                    DebugPrintW("[MediaInfoShellExt] Processing path: %s\n", path.get());
                     std::filesystem::path filepath{ path.get() };
                     // Resolve shortcuts
                     if (filepath.extension().string() == ".url") {
                         std::string url;
                         if (ExtractUrlFromShortcut(filepath, url))
                             filepath = url;
+                        DebugPrintW("[MediaInfoShellExt] Resolved url file to: %s\n", filepath.wstring().c_str());
                     }
                     if (filepath.extension().string() == ".lnk") {
                         WCHAR target_path[MAX_PATH];
                         if (SUCCEEDED(ResolveIt(nullptr, filepath.wstring().c_str(), target_path, sizeof(target_path))))
                             filepath = target_path;
+                        DebugPrintW("[MediaInfoShellExt] Resolved lnk shortcut to: %s\n", filepath.wstring().c_str());
                     }
                     // Append the item path to the existing command, adding quotes and escapes as needed
                     command = wil::str_printf<std::wstring>(LR"-(%s %s)-", command.c_str(), QuoteForCommandLineArg(filepath.wstring()).c_str());
@@ -643,6 +658,7 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
         }
 
         // Invoke application using CreateProcess with the command string prepared above
+        DebugPrintW("[MediaInfoShellExt] Commandline to launch: %s\n", command.c_str());
         wil::unique_process_information process_info;
         STARTUPINFOW startup_info = { sizeof(startup_info) };
         RETURN_IF_WIN32_BOOL_FALSE(CreateProcessW(
@@ -705,5 +721,6 @@ STDAPI DllCanUnloadNow(void) {
     if (winrt::get_module_lock())
         return S_FALSE;
     winrt::clear_factory_cache();
+    DebugPrintW("[MediaInfoShellExt] DllCanUnloadNow returned S_OK.\n");
     return S_OK;
 }
\ No newline at end of file

From 7f20fa378a61b9bf51831df3f8b57f37f8a82802 Mon Sep 17 00:00:00 2001
From: cjee21 <77721854+cjee21@users.noreply.github.com>
Date: Fri, 22 May 2026 15:09:08 +0800
Subject: [PATCH 2/3] ShellExt: Handle non-local (MTP) files

---
 Source/WindowsShellExtension/dllmain.cpp | 82 ++++++++++++++++++------
 Source/WindowsShellExtension/pch.h       |  3 +
 2 files changed, 65 insertions(+), 20 deletions(-)

diff --git a/Source/WindowsShellExtension/dllmain.cpp b/Source/WindowsShellExtension/dllmain.cpp
index ef5e918ec..11de83a26 100644
--- a/Source/WindowsShellExtension/dllmain.cpp
+++ b/Source/WindowsShellExtension/dllmain.cpp
@@ -497,12 +497,15 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
                 if (SUCCEEDED(items->GetItemAt(0, item.put()))) {
                     SFGAOF attribute{};
                     if (SUCCEEDED(item->GetAttributes(SFGAO_FOLDER | SFGAO_STREAM, &attribute))) {
-                        if ((attribute & SFGAO_FOLDER) && !(attribute & SFGAO_STREAM))
+                        if ((attribute & SFGAO_FOLDER) && !(attribute & SFGAO_STREAM)) {
+                            DebugPrintW("[MediaInfoShellExt] Local folder.");
                             is_folder = true;
+                        }
                         else {
                             wil::unique_cotaskmem_string path;
                             if (SUCCEEDED(item->GetDisplayName(SIGDN_FILESYSPATH, &path))) {
                                 std::filesystem::path filepath{ path.get() };
+                                DebugPrintW("[MediaInfoShellExt] Local file; extension: %s\n", filepath.extension().wstring().c_str());
                                 // resolve shortcuts
                                 if (filepath.extension().string() == ".url") {
                                     std::string url;
@@ -521,6 +524,24 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
                                         is_supported_extension = IsSupportedFileExtension(filepath.extension().string());
                                 }
                             }
+                            else {
+                                // Handle MTP etc.
+                                winrt::com_ptr<IShellItem2> pShellItem2;
+                                if (SUCCEEDED(item->QueryInterface(IID_PPV_ARGS(&pShellItem2)))) {
+                                    wil::unique_cotaskmem_string pszExt;
+                                    HRESULT hr = pShellItem2->GetString(PKEY_FileExtension, &pszExt);
+                                    if (SUCCEEDED(hr) && pszExt && pszExt.get()[0] != L'\0') {
+                                        DebugPrintW("[MediaInfoShellExt] Non-local file; extension: %s\n", pszExt.get());
+                                        int sizeNeeded = WideCharToMultiByte(CP_UTF8, 0, pszExt.get(), -1, nullptr, 0, nullptr, nullptr);
+                                        if (sizeNeeded > 0) {
+                                            std::string extension(sizeNeeded, 0);
+                                            WideCharToMultiByte(CP_UTF8, 0, pszExt.get(), -1, &extension[0], static_cast<int>(extension.size()), nullptr, nullptr);
+                                            extension.pop_back(); // Remove extra null-terminator for proper std::string behavior
+                                            is_supported_extension = IsSupportedFileExtension(extension);
+                                        }
+                                    }
+                                }
+                            }
                         }
                     }
                 }
@@ -592,9 +613,10 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
                 auto result = items->GetItemAt(i, item.put());
                 if (SUCCEEDED(result)) {
                     wil::unique_cotaskmem_string path;
+                    std::filesystem::path filepath;
                     result = item->GetDisplayName(SIGDN_FILESYSPATH, &path);
                     if (SUCCEEDED(result)) {
-                        std::filesystem::path filepath{ path.get() };
+                        filepath = path.get();
                         // Resolve shortcuts
                         if (filepath.extension().string() == ".url") {
                             std::string url;
@@ -606,21 +628,29 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
                             if (SUCCEEDED(ResolveIt(nullptr, filepath.wstring().c_str(), target_path, sizeof(target_path))))
                                 filepath = target_path;
                         }
-                        auto command{ wil::str_printf<std::wstring>(LR"-("%s" %s)-", module_path.c_str(), QuoteForCommandLineArg(filepath.wstring()).c_str()) };
-                        wil::unique_process_information process_info;
-                        STARTUPINFOW startup_info = { sizeof(startup_info) };
-                        RETURN_IF_WIN32_BOOL_FALSE(CreateProcessW(
-                            nullptr,
-                            command.data(),
-                            nullptr /* lpProcessAttributes */,
-                            nullptr /* lpThreadAttributes */,
-                            false /* bInheritHandles */,
-                            CREATE_NO_WINDOW,
-                            nullptr,
-                            nullptr,
-                            &startup_info,
-                            &process_info));
                     }
+                    else {
+                        // It may be an MTP or other item with parsing name relative to the desktop
+                        wil::unique_cotaskmem_string parsingName;
+                        HRESULT hrParsing = item->GetDisplayName(SIGDN_DESKTOPABSOLUTEPARSING, &parsingName);
+                        if (SUCCEEDED(hrParsing)) {
+                            filepath = parsingName.get();
+                        }
+                    }
+                    auto command{ wil::str_printf<std::wstring>(LR"-("%s" %s)-", module_path.c_str(), QuoteForCommandLineArg(filepath.wstring()).c_str()) };
+                    wil::unique_process_information process_info;
+                    STARTUPINFOW startup_info = { sizeof(startup_info) };
+                    RETURN_IF_WIN32_BOOL_FALSE(CreateProcessW(
+                        nullptr,
+                        command.data(),
+                        nullptr /* lpProcessAttributes */,
+                        nullptr /* lpThreadAttributes */,
+                        false /* bInheritHandles */,
+                        CREATE_NO_WINDOW,
+                        nullptr,
+                        nullptr,
+                        &startup_info,
+                        &process_info));
                 }
             }
             return S_OK;
@@ -634,10 +664,13 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
             auto result = items->GetItemAt(i, item.put());
             if (SUCCEEDED(result)) {
                 wil::unique_cotaskmem_string path;
+                std::filesystem::path filepath;
                 result = item->GetDisplayName(SIGDN_FILESYSPATH, &path);
                 if (SUCCEEDED(result)) {
-                    DebugPrintW("[MediaInfoShellExt] Processing path: %s\n", path.get());
-                    std::filesystem::path filepath{ path.get() };
+                    // If succeeded then it is a usual local file path
+                    // Only items that report SFGAO_FILESYSTEM have a file system path.
+                    DebugPrintW("[MediaInfoShellExt] Processing local path: %s\n", path.get());
+                    filepath = path.get();
                     // Resolve shortcuts
                     if (filepath.extension().string() == ".url") {
                         std::string url;
@@ -651,9 +684,18 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
                             filepath = target_path;
                         DebugPrintW("[MediaInfoShellExt] Resolved lnk shortcut to: %s\n", filepath.wstring().c_str());
                     }
-                    // Append the item path to the existing command, adding quotes and escapes as needed
-                    command = wil::str_printf<std::wstring>(LR"-(%s %s)-", command.c_str(), QuoteForCommandLineArg(filepath.wstring()).c_str());
                 }
+                else {
+                    // It may be an MTP or other item with parsing name relative to the desktop
+                    wil::unique_cotaskmem_string parsingName;
+                    HRESULT hrParsing = item->GetDisplayName(SIGDN_DESKTOPABSOLUTEPARSING, &parsingName);
+                    if (SUCCEEDED(hrParsing)) {
+                        filepath = parsingName.get();
+                        DebugPrintW("[MediaInfoShellExt] Non-local path: %s\n", filepath.wstring().c_str());
+                    }
+                }
+                // Append the item path to the existing command, adding quotes and escapes as needed
+                command = wil::str_printf<std::wstring>(LR"-(%s %s)-", command.c_str(), QuoteForCommandLineArg(filepath.wstring()).c_str());
             }
         }
 
diff --git a/Source/WindowsShellExtension/pch.h b/Source/WindowsShellExtension/pch.h
index 6ea22df20..f1d803f1b 100644
--- a/Source/WindowsShellExtension/pch.h
+++ b/Source/WindowsShellExtension/pch.h
@@ -28,4 +28,7 @@
 #include <wil/stl.h>
 #include <wil/win32_helpers.h>
 
+// PROPERTYKEY
+#include <propkey.h>
+
 #endif //PCH_H

From 2415dd887363332c736a43c5712fc3e32ed7eeb0 Mon Sep 17 00:00:00 2001
From: cjee21 <77721854+cjee21@users.noreply.github.com>
Date: Tue, 26 May 2026 13:43:01 +0800
Subject: [PATCH 3/3] ShellExt: Remove okToBeSlow check

Revert part of commit 7db573cd9c09e3eb8d31b9f69e6c8bd54b2e7f8b as it has no much benefit and causes regression on some systems.
---
 Source/WindowsShellExtension/dllmain.cpp | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/Source/WindowsShellExtension/dllmain.cpp b/Source/WindowsShellExtension/dllmain.cpp
index 11de83a26..f2cad9366 100644
--- a/Source/WindowsShellExtension/dllmain.cpp
+++ b/Source/WindowsShellExtension/dllmain.cpp
@@ -462,16 +462,10 @@ struct ExplorerCommandHandler : public winrt::implements<ExplorerCommandHandler,
     IFACEMETHODIMP GetState(_In_opt_ IShellItemArray* items, _In_ BOOL okToBeSlow, _Out_ EXPCMDSTATE* cmdState) override {
         // Provide state of File Explorer context menu entry
         // Hide it if registry setting indicates that it should be disabled or file is unsupported, else it is enabled
+        UNREFERENCED_PARAMETER(okToBeSlow);
 
         DebugPrintW("[MediaInfoShellExt] GetState called.\n");
 
-        if (!okToBeSlow) {
-            *cmdState = ECS_DISABLED;
-            // returning E_PENDING requests that a new instance of this object be called back
-            // on a background thread so that it can do work that might be slow
-            return E_PENDING;
-        }
-
 #ifdef MEDIAINFO_QT
         auto shellExtension{ RegGetBool(HKEY_CURRENT_USER, L"Software\\MediaArea.net\\MediaInfo", L"shellExtension") };
         if (shellExtension.has_value() && !shellExtension.value())