Skip to content

Commit 0a70727

Browse files
committed
refactor(networking): remove unnecessary intermediate list in ProcessCurrentQueue
Dispatch tasks directly as items are dequeued from the queue instead of collecting into a separate requestCallbacks list first.
1 parent 586e129 commit 0a70727

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

src/MADE.Networking/Http/NetworkRequestManager.cs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,23 +97,17 @@ public void ProcessCurrentQueue()
9797
{
9898
using var cts = new CancellationTokenSource();
9999
var requestTasks = new List<Task>();
100-
var requestCallbacks = new List<NetworkRequestCallback>();
101100

102101
while (this.CurrentQueue.Count > 0)
103102
{
104103
if (this.CurrentQueue.TryRemove(
105104
this.CurrentQueue.FirstOrDefault().Key,
106105
out NetworkRequestCallback request))
107106
{
108-
requestCallbacks.Add(request);
107+
requestTasks.Add(ExecuteRequestsAsync(this.CurrentQueue, request, cts.Token));
109108
}
110109
}
111110

112-
foreach (NetworkRequestCallback container in requestCallbacks)
113-
{
114-
requestTasks.Add(ExecuteRequestsAsync(this.CurrentQueue, container, cts.Token));
115-
}
116-
117111
Task.WhenAll(requestTasks).GetAwaiter().GetResult();
118112
}
119113
finally

0 commit comments

Comments
 (0)