-
Notifications
You must be signed in to change notification settings - Fork 103
LF-4672 (3) - rtk locations upgrade remove duplication #4099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Duncan-Brain
wants to merge
46
commits into
integration
Choose a base branch
from
rtk-upgrade/locations-2-location-details
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,147
−9,123
Open
Changes from 45 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
43500e1
Make a generic Edit location detail form
Duncan-Brain ff825e8
Replace Edit Barn container with new generic form
Duncan-Brain ad0a7eb
add new translation string to match others
Duncan-Brain 9055788
Pattern emerging for the formatting function extract into util
Duncan-Brain 4f53cec
Replace Edit ceremonial area with generic component
Duncan-Brain 4d12361
cleanup console log
Duncan-Brain b1d9032
Remove edit farm site boundary and use generic component
Duncan-Brain 7a28a86
Remove edit field location container and replace with generic component
Duncan-Brain 23d11f1
remove garden container and replace with generic
Duncan-Brain 14eb91a
remove greenhouse edit container and replace with generic
Duncan-Brain ab61e68
Map filter strings are actually present, use template string instead …
Duncan-Brain aa52beb
replace edit natural area container with generic component
Duncan-Brain 13d8a48
remove residence edit container and replace with generic component
Duncan-Brain aacd64a
remove surface water edit form and replace with generic
Duncan-Brain 814b768
remove edit buffer zone form, replace with generic component
Duncan-Brain c0e6680
remove edit fence form containere and replace with generic component
Duncan-Brain 8d802a1
Remove watercourse edit form container and replace with generic
Duncan-Brain 861a029
remove gate edit form and use generic component
Duncan-Brain 4f22d7e
cleanup unused imports and functions
Duncan-Brain 6e52262
remove soil sample location edit form and use generic component
Duncan-Brain bb88c47
remove edit water valve form and replace with generic component
Duncan-Brain c9dc724
Make the routes files into a reusable file and delete duplicated code
Duncan-Brain 332b18d
WIP first draft of the post location by type form
Duncan-Brain 45d464f
Replace post barn route with reusable route
Duncan-Brain b2c86f0
Delete the rest of the post forms and sagas
Duncan-Brain b02d9b9
Remove get locations saga and slices
Duncan-Brain 85ff3f8
Remove soil sample selector after deletion, it was known but separati…
Duncan-Brain e1d1133
WIP Make reusable component skeleton that works for Barn
Duncan-Brain e65d903
refactor and create util for component reuse
Duncan-Brain e193a7f
Fix surface water properties picked
Duncan-Brain a03c6ba
Generic components work for all areas in edit and post
Duncan-Brain 08af12c
Update geneirc componetns for lines
Duncan-Brain 198d4e4
Adapt generic wrapper for use with points
Duncan-Brain 22beaa5
Make on cancel not a boolean to handle type error
Duncan-Brain 1a57c51
Use generic component in container, delete unused files
Duncan-Brain 7dd1d96
Move area line and point details files
Duncan-Brain 8b1f07b
Replace duplicative stories with combined story and rtk store for new…
Duncan-Brain ca152a0
Add missing reducers causing storybook crash on new stories using state
Duncan-Brain 93d771b
remove location type reducers
Duncan-Brain 737681c
export types for location stories util
Duncan-Brain fee73b6
Remove warning box now that snackbars are used
Duncan-Brain 620e6e3
Warningbox would show for all errors, lets not do that actually
Duncan-Brain ca3ed02
Replace Barn
Duncan-Brain bc6c186
remove unnecessary dispatch
Duncan-Brain 9eadc0f
move files up a folder
Duncan-Brain 22a4296
Merge branch 'integration' into rtk-upgrade/locations-2-location-details
Duncan-Brain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,6 +124,7 @@ | |
| "MAP": { | ||
| "FAIL_PATCH": "Failed to update", | ||
| "FAIL_POST": "Failed to add new", | ||
| "FAIL_DELETE": "Failed to retire", | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using snackbars instead of WarningBox |
||
| "SUCCESS_DELETE": "Successfully retired", | ||
| "SUCCESS_PATCH": "Successfully updated", | ||
| "SUCCESS_POST": "Successfully saved" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 0 additions & 120 deletions
120
packages/webapp/src/components/LocationDetailLayout/AreaDetails/Barn/index.jsx
This file was deleted.
Oops, something went wrong.
57 changes: 0 additions & 57 deletions
57
packages/webapp/src/components/LocationDetailLayout/AreaDetails/CeremonialArea/index.jsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing some reducers...