Allow LinearSolve v4 - #135
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Conversation
LinearSolve is releasing a breaking v4 (batched matrix right-hand sides, SciML/LinearSolve.jl#1072). AlgebraicMultigrid uses only the stable LinearSolve API (SciMLLinearSolveAlgorithm, build_linear_solution, the LinearCache interface), none of which changes in v4, so widening compat is sufficient. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
... bump - they are now at v5... |
Collaborator
|
Note that the CI is still at v3 |
Contributor
|
... interesting why... I ran tests locally with v5, all ok. Also had a look at the code, nothing which would hit the very reasonable breaking changes (don't put the linear solver context aka "cache" into the solution object anymore). |
Collaborator
|
Superseded by #136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinearSolve.jl is preparing a breaking v4.0.0 (batched matrix right-hand sides, SciML/LinearSolve.jl#1072, at @ChrisRackauckas's direction). The breaking surface is only the solution shape for matrix right-hand sides (
ubecomesn×kinstead of a flattened vector) plus an informative error for matrixbwith iterative solvers — nothing AlgebraicMultigrid touches:SciMLLinearSolveAlgorithm,init/solve!, theLinearCacheinterface,build_linear_solution, and theprecsAPI are all unchanged.Verified locally against LinearSolve v4 (this branch dev'd together with the v4 branch):
AlgebraicMultigridJL()(Ruge–Stuben) andSmoothedAggregationAMGas LinearSolve algorithms solve correctly withReturnCode.Success;aspreconditioner(ruge_stuben(A))withKrylovJL_GMRESyields bit-identical residuals under v3.87.0 and v4.0.0.Includes a patch bump to 2.0.1 so this can be tagged directly. Widening compat before v4 is registered lets the ecosystem resolve as soon as v4 lands.