Fix permissions check on Resume GPS trip - #98955
Open
GCyganek wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@codex please review |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
7 tasks
GCyganek
marked this pull request as ready for review
August 19, 2026 09:46
melvin-bot
Bot
requested review from
JmillsExpensify and
truph01
and removed request for
a team and
JmillsExpensify
August 19, 2026 09:46
Contributor
Author
|
@dukenv0307 could you review as this is part of the GPS project? |
Contributor
|
Sure |
Contributor
|
@dukenv0307 Could you unassign me from here and the issue as well? |
mountiny
self-requested a review
August 19, 2026 18:33
Contributor
|
ping me when ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The "Resume" button on a stopped GPS trip called
resumeGpsTripdirectly, skipping the location services and background permissions checks that "Start" performs. It now callscheckSettingsAndPermissions, andBackgroundLocationPermissionsFlow'sonGrantresolves toresumeGpsTripwhen the trip is stopped, otherwisestartGpsTrip.Fixed Issues
$ #98954
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-19.at.09.44.43.mov
iOS: Native
Screen.Recording.2026-08-19.at.09.31.01.mov