Skip to content

Fix permissions check on Resume GPS trip - #98955

Open
GCyganek wants to merge 1 commit into
Expensify:mainfrom
software-mansion-labs:@GCyganek/gps/fix-resume-permissions-check
Open

Fix permissions check on Resume GPS trip#98955
GCyganek wants to merge 1 commit into
Expensify:mainfrom
software-mansion-labs:@GCyganek/gps/fix-resume-permissions-check

Conversation

@GCyganek

Copy link
Copy Markdown
Contributor

Explanation of Change

The "Resume" button on a stopped GPS trip called resumeGpsTrip directly, skipping the location services and background permissions checks that "Start" performs. It now calls checkSettingsAndPermissions, and BackgroundLocationPermissionsFlow's onGrant resolves to resumeGpsTrip when the trip is stopped, otherwise startGpsTrip.

Fixed Issues

$ #98954
PROPOSAL: N/A

Tests

  1. FAB > Track distance > GPS
  2. Start a GPS trip
  3. Cover some distance
  4. Stop the GPS trip so that it has start and stop waypoints
  5. Go to location permissions settings and change them to Don't allow/Never
  6. Go back to the app
  7. Tap Resume
  8. Verify user is asked to allow location permissions to continue the trip and that no error is shown above the Resume button
  9. Verify that steps 6.-8. apply to all other permissions settings apart from "Always allowed + Precise location enabled" combination
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-08-19.at.09.44.43.mov
iOS: Native
Screen.Recording.2026-08-19.at.09.31.01.mov

@GCyganek

Copy link
Copy Markdown
Contributor Author

@codex please review

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...tep/IOURequestStepDistanceGPS/GPSButtons/index.tsx 0.00% <0.00%> (ø)
... and 107 files with indirect coverage changes

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 4321391696

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@GCyganek
GCyganek marked this pull request as ready for review August 19, 2026 09:46
@GCyganek
GCyganek requested review from a team as code owners August 19, 2026 09:46
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and truph01 and removed request for a team and JmillsExpensify August 19, 2026 09:46
@melvin-bot

melvin-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 19, 2026 09:46
@GCyganek

Copy link
Copy Markdown
Contributor Author

@dukenv0307 could you review as this is part of the GPS project?

@dukenv0307

Copy link
Copy Markdown
Contributor

Sure

@truph01

truph01 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@dukenv0307 Could you unassign me from here and the issue as well?

@dukenv0307
dukenv0307 requested review from dukenv0307 and removed request for truph01 August 19, 2026 10:43
@mountiny
mountiny self-requested a review August 19, 2026 18:33
@mountiny

Copy link
Copy Markdown
Contributor

ping me when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants