prevent ParticleType instances from being kept alive forever#1113
Open
earthwise01 wants to merge 1 commit into
Open
prevent ParticleType instances from being kept alive forever#1113earthwise01 wants to merge 1 commit into
ParticleType instances from being kept alive forever#1113earthwise01 wants to merge 1 commit into
Conversation
maddie480-bot
added
the
1: review needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the constructors for
Monocle.ParticleTypeadd all created instances to a private staticAllTypeslist, which is never used anywhere else. While this is fine in vanilla, this causes minor issues for mods which create newParticleTypes on the fly (e.g. to allow customization throughEntityData, etc), as all created instances will be kept alive forever.This PR fixes this by removing the
AllTypes.Add(this)calls from both constructors, and also applies an[Obsolete]attribute to the list itself.