From b585cdfc1066c71108619d5c3da9ec24824fd91e Mon Sep 17 00:00:00 2001 From: Lazaro Alonso Date: Sun, 21 Jun 2026 11:42:31 +0200 Subject: [PATCH 1/2] mv into settings --- .../ui/MainPanel/RemoteIcechunk.tsx | 262 ++++++++++-------- 1 file changed, 141 insertions(+), 121 deletions(-) diff --git a/src/components/ui/MainPanel/RemoteIcechunk.tsx b/src/components/ui/MainPanel/RemoteIcechunk.tsx index f96be577..98d100ac 100644 --- a/src/components/ui/MainPanel/RemoteIcechunk.tsx +++ b/src/components/ui/MainPanel/RemoteIcechunk.tsx @@ -97,6 +97,9 @@ type Props = { const RemoteIcechunk = ({ setInitStore, onOpenDescription }: Props) => { const [url, setUrl] = useState(''); + + const [showSettings, setShowSettings] = useState(false); + const [refType, setRefType] = useState('branch'); const [refValue, setRefValue] = useState('main'); @@ -169,143 +172,160 @@ const RemoteIcechunk = ({ setInitStore, onOpenDescription }: Props) => { - {/* Branch / Tag / Snapshot */} -
-
- {REF_TABS.map(({ value, label }) => ( - - ))} -
- setRefValue(e.target.value)} - /> -
- - {/* Storage options */} + {/* Settings toggle */}
- {showStorage && ( -
-
- {/* Credentials Select */} -
- Credentials - -
+ {showSettings && ( +
- {/* Cache Select */} -
- Cache - -
- + {label} + + ))}
- + setRefValue(e.target.value)} + />
- )} -
- {/* fetchClient headers */} -
- - {showFetchClientHeaders && ( - - )} -
+ {/* Storage options */} +
+ + {showStorage && ( +
+
- {/* Advanced */} -
- - {showAdvanced && ( -
-
- - setMaxRetries(Number(e.target.value))} - /> -
-
- - setRetryDelay(Number(e.target.value))} - /> -
+ {/* Credentials Select */} +
+ Credentials + +
+ + {/* Cache Select */} +
+ Cache + +
+ +
+ +
+ )} +
+ + {/* fetchClient headers */} +
+ + {showFetchClientHeaders && ( + + )} +
+ + {/* Advanced */} +
+ + {showAdvanced && ( +
+
+ + setMaxRetries(Number(e.target.value))} + /> +
+
+ + setRetryDelay(Number(e.target.value))} + /> +
+
+ )}
+
)}
-
); }; From 6ac93391de88980750c5e72b09a854c26b092a94 Mon Sep 17 00:00:00 2001 From: Lazaro Alonso Date: Sun, 21 Jun 2026 11:56:01 +0200 Subject: [PATCH 2/2] parse as int instead --- src/components/ui/MainPanel/RemoteIcechunk.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/ui/MainPanel/RemoteIcechunk.tsx b/src/components/ui/MainPanel/RemoteIcechunk.tsx index 98d100ac..44322417 100644 --- a/src/components/ui/MainPanel/RemoteIcechunk.tsx +++ b/src/components/ui/MainPanel/RemoteIcechunk.tsx @@ -308,7 +308,7 @@ const RemoteIcechunk = ({ setInitStore, onOpenDescription }: Props) => { type="number" className="w-16" value={maxRetries} - onChange={e => setMaxRetries(Number(e.target.value))} + onChange={e => setMaxRetries(Math.max(0, parseInt(e.target.value, 10) || 0))} />
@@ -317,7 +317,7 @@ const RemoteIcechunk = ({ setInitStore, onOpenDescription }: Props) => { type="number" className="w-20" value={retryDelay} - onChange={e => setRetryDelay(Number(e.target.value))} + onChange={e => setRetryDelay(Math.max(0, parseInt(e.target.value, 10) || 0))} />