Skip to content

[Bug] VariableMoveCategoryAttr Moves, (Tera Blast, Shell Side Arm, Starstorm) do not consider Physical-Activating Abilities #1278

Description

@Snailman11

Describe the bug

Tera Blast, Shell Side Arm and Tera Starstorm do not activate Abilities that would activate after being hit by a move in the Physical Category and always act as moves in the Special category.
This causes those moves to always activate moves that use move.category === MoveCategory.SPECIAL, such as Ice Scales and Flare Boost, and never activate Abilities that use move.category === MoveCategory.PHYSICAL` such as Ice Face and Weak Armor.

Reproduction

Start with a Neutral Nature Physical-Leaning Pokemon, such as Spearow or Bagon
-Change Opp Ability to Ice Scales and compare damage pre-Gastro Acid

	MOVESET_OVERRIDE: [MoveId.SHELL_SIDE_ARM, MoveId.GASTRO_ACID, MoveId.TERA_BLAST],
	ABILITY_OVERRIDE: AbilityId.SYNCHRONIZE,

	ENEMY_LEVEL_OVERRIDE: 4,
	ENEMY_SPECIES_OVERRIDE: SpeciesId.GLALIE,

	ENEMY_MOVESET_OVERRIDE: [MoveId.SPLASH],
	ENEMY_IVS_OVERRIDE: [31, 31, 31, 31, 31, 31],
	ENEMY_ABILITY_OVERRIDE: AbilityId.WEAK_ARMOR,

Expected behavior

Shell Side arm. Tera Blast, and Tera Starstorm should activate on Abilities dependent on the Forecasted Category.

https://replay.pokemonshowdown.com/gen9customgame-2393942726-1toat52c2dll193mvlg60h0i3hh641epw

Screenshots / Videos

Physical Shell Side Arm Activates Ice Scales

Shell.Sidearm.Ice.Scales.mp4

Physical Shell Side Arm does not activate Weak Armor

PR.Weak.Armor.SSA.mp4

Session export file

No response

User data export file

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    AbilityFor ability implementations/interactionsP2MINOR. Incorrect behavior but is not game breaking.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions