Skip to content

Robertomonteromiguel/gitlab collapsible sections#7095

Merged
robertomonteromiguel merged 6 commits into
mainfrom
robertomonteromiguel/gitlab_collapsible_sections
Jun 9, 2026
Merged

Robertomonteromiguel/gitlab collapsible sections#7095
robertomonteromiguel merged 6 commits into
mainfrom
robertomonteromiguel/gitlab_collapsible_sections

Conversation

@robertomonteromiguel

@robertomonteromiguel robertomonteromiguel commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The after_script log-rendering logic (collapsible log sections + run summary + navigation banner) was duplicated/inline in .gitlab/ssi_gitlab-ci.yml. This PR extracts it into a single reusable script, utils/scripts/gitlab_print_logs.sh, and wires it into the three jobs that need it.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/scripts/gitlab_print_logs.sh                                      @DataDog/system-tests-core
.gitlab/ssi_gitlab-ci.yml                                               @DataDog/system-tests-core
utils/scripts/ci_orchestrators/gitlab_exporter.py                       @DataDog/system-tests-core

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 5, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

Pipelines  Tests

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 6 Pipeline jobs failed

Testing the test | System Tests (php, dev) / End-to-end #1 / apache-mod-7.0-zts 1   View in Datadog   GitHub Actions

🧪 1 Test failed

tests.ffe.test_exposures.Test_FFE_Exposure_Events.test_ffe_multiple_remote_config_files[apache-mod-7.0-zts] from system_tests_suite   View in Datadog (Fix with Cursor) 
AssertionError: Expected to find flags 'test-flag-1' or 'test-flag-2' in exposure events, found: set()
assert ('test-flag-1' in set() or 'test-flag-2' in set())
 +  where 'test-flag-1' = <tests.ffe.test_exposures.Test_FFE_Exposure_Events object at 0x7f24c97fe4b0>.flag_1
 +  and   'test-flag-2' = <tests.ffe.test_exposures.Test_FFE_Exposure_Events object at 0x7f24c97fe4b0>.flag_2

self = <tests.ffe.test_exposures.Test_FFE_Exposure_Events object at 0x7f24c97fe4b0>

    def test_ffe_multiple_remote_config_files(self):
        """Test that FFE correctly handles multiple remote config files with different flags."""
        assert self.r1.status_code == 200, f"First flag evaluation failed: {self.r1.text}"
...

Testing the test | System Tests (cpp_httpd, prod) / End-to-end #1 / httpd 1   View in Datadog   GitHub Actions

Testing the test | System Tests (cpp_kong, dev) / End-to-end #2 / kong 2   View in Datadog   GitHub Actions

View all 6 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 43c1c19 | Docs | Datadog PR Page | Give us feedback!

robertomonteromiguel and others added 3 commits June 8, 2026 15:19
@robertomonteromiguel
rebase
e23a3ea
@robertomonteromiguel @cursoragent
SSI: make logs debug doc URL parametrizable and capture docker-ssi ru…
e92a3bb 
…n summary

Add DEBUG_LOGS_DOC_URL so the shared gitlab_print_logs.sh banner links to the
scenario-specific debug docs (aws onboarding, k8s, docker-ssi), and capture the
docker-ssi run.sh output to run_output.log with pipefail so the run summary is
re-printed in the after_script.

Co-authored-by: Cursor <cursoragent@cursor.com>
@robertomonteromiguel
k8s build section
43c1c19
@robertomonteromiguel robertomonteromiguel marked this pull request as ready for review June 9, 2026 10:08
@robertomonteromiguel robertomonteromiguel requested a review from a team as a code owner June 9, 2026 10:08
@robertomonteromiguel robertomonteromiguel merged commit 5e07d58 into main Jun 9, 2026
1982 of 1988 checks passed
@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/gitlab_collapsible_sections branch June 9, 2026 10:08
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 9, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 43c1c19625

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .gitlab/ssi_gitlab-ci.yml
--env ci \
--verbose \
--xpath-tag "test.codeowners=/testcase/properties/property[@name='test.codeowners']"
# Render all report logs as collapsible sections + run summary + banner.

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore K8s JUnit upload before printing logs

In the K8s base job after_script, this replacement jumps straight from feature-parity handling to gitlab_print_logs.sh; the previous datadog-ci junit upload reports/logs*/reportJunit.xml ... block was removed here. For every K8S_LIB_INJECTION job that produces reportJunit.xml, Datadog Test Optimization will stop receiving K8s results while the Docker SSI job still uploads them, so CI dashboards/ownership tags lose coverage for these workflows. Please keep the JUnit upload block before rendering the collapsible logs.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@robertomonteromiguel