Skip to content

Set repo_overrides for @DataDog/profiling#7093

Merged
cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/profiling-owner
Jun 5, 2026
Merged

Set repo_overrides for @DataDog/profiling#7093
cbeauchesne merged 1 commit into
mainfrom
cbeauchesne/profiling-owner

Conversation

@cbeauchesne

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/_features.py                                                      @DataDog/system-tests-core

@cbeauchesne cbeauchesne marked this pull request as ready for review June 5, 2026 11:40
@cbeauchesne cbeauchesne requested a review from a team as a code owner June 5, 2026 11:40
@cbeauchesne cbeauchesne merged commit 06dbf8d into main Jun 5, 2026
428 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/profiling-owner branch June 5, 2026 11:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a45853d2a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread utils/_features.py
"dd-trace-php": "@DataDog/profiling-php",
"dd-trace-py": "@DataDog/profiling-python",
"dd-trace-rb": "@DataDog/profiling-rb",
})

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the Nginx profiling owner override

The PROFILING scenario is part of the tracer_release workflow, and manifests/cpp_nginx.yml only disables the process-tags checks, so Test_Profile::test_library and test_agent still run for cpp_nginx. In an nginx-datadog CI run, _get_ci_repo_name() resolves to nginx-datadog; because this new override map omits that repo, those profiling failures continue to be assigned to the default @DataDog/profiling instead of the C++ owner used by the other per-repo maps.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant