Set repo_overrides for @DataDog/profiling#7093
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a45853d2a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "dd-trace-php": "@DataDog/profiling-php", | ||
| "dd-trace-py": "@DataDog/profiling-python", | ||
| "dd-trace-rb": "@DataDog/profiling-rb", | ||
| }) |
There was a problem hiding this comment.
Include the Nginx profiling owner override
The PROFILING scenario is part of the tracer_release workflow, and manifests/cpp_nginx.yml only disables the process-tags checks, so Test_Profile::test_library and test_agent still run for cpp_nginx. In an nginx-datadog CI run, _get_ci_repo_name() resolves to nginx-datadog; because this new override map omits that repo, those profiling failures continue to be assigned to the default @DataDog/profiling instead of the C++ owner used by the other per-repo maps.
Useful? React with 👍 / 👎.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present