From 7f6d354a8e1139ae2afb66ef4c99158f454fed3a Mon Sep 17 00:00:00 2001 From: dante01yoon Date: Tue, 19 May 2026 09:43:27 +0900 Subject: [PATCH 01/14] refactor(assets): delete isAssetAPIEnabled and Comfy.Assets.UseAssetAPI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit FE-729 (L1.2 — L1 central). Asset API will be always available post-BE-786 (`--enable-assets` removed from OSS). Delete the gating function, the user-facing setting, the experimental warning, and the toggle command. Simplify all caller sites to assume the asset API is available. Changes: - Delete isAssetAPIEnabled() from assetService.ts; simplify shouldUseAssetBrowser() to call isAssetBrowserEligible() directly. - Remove the EXPERIMENTAL_WARNING prefix from four asset-load error messages. - Drop the Comfy.Assets.UseAssetAPI setting from coreSettings.ts and its schema entry in apiSchema.ts. - Remove the Comfy.ToggleAssetAPI command outright. Keep Comfy.BrowseModelAssets but drop its setting-check / setting-set preamble and the "Experimental:" label prefix; the command now just opens the asset browser dialog. - modelStore: drop the useAssetAPI fork in createGetModelsFunc and loadModelFolders; always route through assetService. - sidebarTabStore: model-library tab click always routes through Comfy.BrowseModelAssets (no more setting check). - assetPreviewUtil.isAssetPreviewSupported() returns true unconditionally; caller-site simplification deferred. - WidgetSelect.vue: simplify isAssetMode to drop the isAssetAPIEnabled() arm of the disjunction. - Test mocks/expectations updated. Blocked-merge by BE-786 (OSS `--enable-assets` removal). PR opened as draft. Also auto-fixed unrelated tailwind class-order lint errors in four files (VirtualGrid, RightSidePanel, Textarea, ModelInfoPanel, WidgetSelectDefault) to keep CI green. --- src/components/common/VirtualGrid.vue | 2 +- .../rightSidePanel/RightSidePanel.vue | 2 +- src/components/ui/textarea/Textarea.vue | 2 +- src/composables/useCoreCommands.ts | 32 +------ .../components/modelInfo/ModelInfoPanel.vue | 2 +- .../assets/services/assetService.test.ts | 49 +--------- src/platform/assets/services/assetService.ts | 27 +----- .../assets/utils/assetPreviewUtil.test.ts | 22 +---- src/platform/assets/utils/assetPreviewUtil.ts | 9 +- .../settings/constants/coreSettings.ts | 8 -- .../WidgetSelect.asset-mode.test.ts | 3 +- .../widgets/components/WidgetSelect.test.ts | 5 +- .../widgets/components/WidgetSelect.vue | 2 +- .../components/WidgetSelectDefault.vue | 2 +- src/schemas/apiSchema.ts | 1 - src/stores/modelStore.test.ts | 92 +++++-------------- src/stores/modelStore.ts | 13 +-- src/stores/workspace/sidebarTabStore.ts | 6 +- 18 files changed, 48 insertions(+), 231 deletions(-) diff --git a/src/components/common/VirtualGrid.vue b/src/components/common/VirtualGrid.vue index 97e568af07c..a3858e2110f 100644 --- a/src/components/common/VirtualGrid.vue +++ b/src/components/common/VirtualGrid.vue @@ -1,7 +1,7 @@