Skip to content

Previous result no longer cached, since PR 15027 (fast-disk doesn't resolve) Also, will old less-aggressive-pinning return as a feature? #15556

Description

@808charlie

Since PR 15027, cache of previous generations seems non-existent.

I was really happy with v28, as linux managed caching perfectly in the 112GB system RAM I allocate (GPU=5090).

I tried --fast-disk, but whilst it stops pinning, it doesn't bring back the caching of generation. That's the one thing I wanted Comfy to pin some space for.

@rattus128 , you wrote "We can make the old way a separate option but its probably best to just consolidate with this and --fast-disk" in the pull.
Is there a chance the old option will return?

Perhaps there's a setting that can achieve this I overlooked?

I can't say I've seen any massive slow-ups since the pinning, and your work with pinning has been a huge benefit in allowing one to smoothly use models beyond one's VRAM - thank you. 15027 seems somewhat without benefit on my spec as yet.
If I flicked between an int8-convrot, a BF16, and finetune in a workflow - linux would cache them all just fine without need for Comfy to take responsibility.

Steps to reproduce

  1. Generate an image in Krea with one sampler (run)
  2. Switch to another sampler (run)
  3. Switch back (run).

Run 3 used to generate from cache. Same for changing seeds. Now it doesn't.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions