Skip to content

Added listener to exit process when db connection fails #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henrymollman wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added listener to exit process when db connection fails #1752

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6457073
Added listener to exit process when db connection fails
Oct 7, 2016
f193650
Separated functions, added tests
Oct 8, 2016
bfa69b9
Added more unit tests and fixed linting
Oct 11, 2016
a96af0e
Added env variable to hopefully pass functional tests
Oct 11, 2016
a78bbf5
Did the sensible thing
Oct 12, 2016
caea764
Merge branch 'master' into shutdown-api-on-db-disconnect
anandkumarpatel Jun 13, 2017
41f46d7
Merge remote-tracking branch 'origin/master' into shutdown-api-on-db-…
Jun 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/models/mongo/mongoose-control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,19 @@ mongooseControl.start = function (cb) {
}

mongoose.connect(process.env.MONGO, mongooseOptions, cb)
mongoose.connection.on('disconnected', function () {
Copy link
Copy Markdown
Contributor

@anandkumarpatel anandkumarpatel Oct 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, to clean this up a bit can you move this to a helper function?

mongooseControl._handleDisconnect()

uncle bob and I would also be very happy if you broke that down further into

mongooseControl._exitIfNotOpened() {...}

mongooseControl._exitIfConnectionNeverMade () {...}

if (!mongoose.connection._hasOpened) {
log.fatal({message: 'Failed to connect to ' + process.env.MONGO}, 'failed to establish a connection to mongodb')
process.exit(1)
} else {
log.error({message: 'Lost connection to ' + process.env.MONGO})
setTimeout(function () {
if (!mongoose.connection.readyState) {
process.exit(1)
}
}, 10000)
}
})
}

mongooseControl.stop = function (cb) {
Expand Down