Skip to content

Commit 45df437

Browse files
kmorelJieyangChen7
authored andcommitted
Make hipCUB dependency privacy
When compiling with HIP, there is a hipCUB dependency. For reasons, you cannot load the library directly. Instead, we add the include directories to the library. These were declared public, but other projects importing the library would not necessarily have these dependent libraries. Thus, declare them private. They should only be needed when compiling the MGARD library.
1 parent 73ce987 commit 45df437

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -218,9 +218,9 @@ if (MGARD_ENABLE_HIP)
218218
# is because different sources require different compilers. So, instead just
219219
# grab the include directories.
220220
target_include_directories(mgard-library
221-
PUBLIC $<TARGET_PROPERTY:hip::hipcub,INTERFACE_INCLUDE_DIRECTORIES>
222-
PUBLIC $<TARGET_PROPERTY:roc::rocprim_hip,INTERFACE_INCLUDE_DIRECTORIES>
223-
PUBLIC $<TARGET_PROPERTY:roc::rocprim,INTERFACE_INCLUDE_DIRECTORIES>
221+
PRIVATE $<TARGET_PROPERTY:hip::hipcub,INTERFACE_INCLUDE_DIRECTORIES>
222+
PRIVATE $<TARGET_PROPERTY:roc::rocprim_hip,INTERFACE_INCLUDE_DIRECTORIES>
223+
PRIVATE $<TARGET_PROPERTY:roc::rocprim,INTERFACE_INCLUDE_DIRECTORIES>
224224
)
225225
endif()
226226

0 commit comments

Comments
 (0)