Skip to content

Commit c751adb

Browse files
authored
Merge pull request #281 from Azure/t-achhatkuli/dev/deploy-report-parse-comment
Explain swallow-by-design parse-failure handling in DeploymentReport
2 parents 0d5d107 + 0d0e755 commit c751adb

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

src/DeploymentReport.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ export function parseDeploymentReport(xml: string): DeploymentReport {
5454
try {
5555
parsed = parser.parse(xml);
5656
} catch {
57+
// Reporting is best-effort and must never fail a deployment: malformed or
58+
// unexpected report XML yields an empty result so the summary simply omits
59+
// the changes section instead of surfacing an error.
5760
return { operations: [], alerts: [] };
5861
}
5962

0 commit comments

Comments
 (0)