2025 SSEI

Author: Benjin

.github/workflows/pr-check.yml

@@ -82,56 +82,67 @@ jobs:
         echo "::add-mask::${SA_PASSWORD}"
         echo "SA_PASSWORD=${SA_PASSWORD}" >> "$GITHUB_ENV"
 
-    - name: Download SQL Server 2022 Express installer (Windows)
+    - name: Download SQL Server 2025 Express installer (Windows)
       if: runner.os == 'Windows'
       shell: pwsh
       run: |
-        $ssei  = Join-Path $env:RUNNER_TEMP 'SQL2022-SSEI-Expr.exe'
+        $ssei  = Join-Path $env:RUNNER_TEMP 'SQL2025-SSEI-Expr.exe'
         $media = Join-Path $env:RUNNER_TEMP 'sql-media'
-        # Stable Microsoft fwlink for the SQL Server 2022 Express bootstrapper (SSEI)
+        # Stable Microsoft fwlink redirecting to the SQL Server 2025 Express bootstrapper (SSEI)
         Invoke-WebRequest -Uri 'https://go.microsoft.com/fwlink/?linkid=2216019' -OutFile $ssei
-        # Tell the bootstrapper to download (not install) the full installer package
-        & $ssei /Quiet /Action=Download /Language=en-US /MediaPath=$media /MediaType=Core /HideProgressBar
-        if ($LASTEXITCODE -ne 0) { throw "SSEI download failed with exit code $LASTEXITCODE" }
+        Write-Host "Downloaded SSEI: $((Get-Item $ssei).Length) bytes"
+
+        # Run SSEI in download-only mode. Use Start-Process -Wait so we get a real exit code
+        # (PowerShell's `&` returns asynchronously for installer-class executables).
+        $p = Start-Process -FilePath $ssei -Wait -PassThru -ArgumentList @(
+          '/Quiet',
+          '/Action=Download',
+          '/Language=en-US',
+          "/MediaPath=$media",
+          '/MediaType=Core',
+          '/HideProgressBar'
+        )
+        if ($p.ExitCode -ne 0) { throw "SSEI download failed with exit code $($p.ExitCode)" }
+
+        Write-Host "=== Media directory contents ==="
         Get-ChildItem $media
 
     - name: Install SQL Server Express with SA auth (Windows)
       if: runner.os == 'Windows'
       shell: pwsh
       run: |
         $media = Join-Path $env:RUNNER_TEMP 'sql-media'
-        # SSEI produces a self-extracting installer (SQLEXPR*.exe). Extract its contents first.
         $selfExtract = Get-ChildItem $media -Filter 'SQLEXPR*.exe' | Select-Object -First 1
         if (-not $selfExtract) { throw "Installer EXE not found in $media" }
+
         $extracted = Join-Path $env:RUNNER_TEMP 'sql-extracted'
         Write-Host "Extracting $($selfExtract.FullName) -> $extracted"
-        & $selfExtract.FullName /Q /X:"$extracted" | Out-Null
-        # Self-extraction is async; wait for setup.exe to appear
-        $deadline = (Get-Date).AddMinutes(2)
-        while (-not (Test-Path (Join-Path $extracted 'setup.exe'))) {
-          if ((Get-Date) -gt $deadline) { throw "Extraction did not complete in time" }
-          Start-Sleep -Seconds 2
-        }
+        $extract = Start-Process -FilePath $selfExtract.FullName -Wait -PassThru `
+          -ArgumentList '/Q', "/X:$extracted"
+        if ($extract.ExitCode -ne 0) { throw "Extraction failed with exit code $($extract.ExitCode)" }
 
         $setup = Join-Path $extracted 'setup.exe'
+        if (-not (Test-Path $setup)) { throw "setup.exe not found at $setup" }
+
         Write-Host "Running $setup with SECURITYMODE=SQL"
-        & $setup `
-          /Q `
-          /ACTION=Install `
-          /FEATURES=SQLEngine `
-          /INSTANCENAME=SQLEXPRESS `
-          /SECURITYMODE=SQL `
-          /SAPWD="$env:SA_PASSWORD" `
-          /TCPENABLED=1 `
-          /IACCEPTSQLSERVERLICENSETERMS `
-          /UPDATEENABLED=False `
-          /SQLSYSADMINACCOUNTS="BUILTIN\Administrators"
-        if ($LASTEXITCODE -ne 0) {
-          Write-Host "Setup failed with exit code $LASTEXITCODE"
-          # Surface the most recent setup logs to make failures diagnosable
-          $logDir = 'C:\Program Files\Microsoft SQL Server\160\Setup Bootstrap\Log'
-          if (Test-Path $logDir) {
-            Get-ChildItem $logDir -Recurse -Filter 'Summary*.txt' |
+        $install = Start-Process -FilePath $setup -Wait -PassThru -ArgumentList @(
+          '/Q',
+          '/ACTION=Install',
+          '/FEATURES=SQLEngine',
+          '/INSTANCENAME=SQLEXPRESS',
+          '/SECURITYMODE=SQL',
+          "/SAPWD=$env:SA_PASSWORD",
+          '/TCPENABLED=1',
+          '/IACCEPTSQLSERVERLICENSETERMS',
+          '/UPDATEENABLED=False',
+          '/SQLSYSADMINACCOUNTS=BUILTIN\Administrators'
+        )
+
+        if ($install.ExitCode -ne 0) {
+          Write-Host "Setup failed with exit code $($install.ExitCode)"
+          $logRoot = 'C:\Program Files\Microsoft SQL Server'
+          if (Test-Path $logRoot) {
+            Get-ChildItem $logRoot -Recurse -Filter 'Summary*.txt' -ErrorAction SilentlyContinue |
               Sort-Object LastWriteTime -Descending | Select-Object -First 1 |
               ForEach-Object { Write-Host "=== $($_.FullName) ==="; Get-Content $_.FullName }
           }